Project

General

Profile

Actions

Feature #248

closed

Port version 1.5 VDC code to 1.6

Added by Ole Hansen about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
High
Assignee:
Target version:
Start date:
11/28/2017
Due date:
% Done:

100%

Estimated time:
16.00 h
Spent time:
Responsible:

Description

Make the old VDC code from version 1.5 available as an optional plug-in in version 1.6 for debugging and comparison purposes.

Actions #1

Updated by Ole Hansen about 5 years ago

  • % Done changed from 0 to 70

Ported the v1.5 VDC code to the v1.6 development branch in directory OldVDC. All THaVDC* classes have been renamed to OldVDC* to make the class names unambiguous. (Namespaces have a tendency to cause confusion if a lot of classes have identical names.)

The one difference to the original VDC code is that the database read functions have been changed to the 1.6 format readers for consistency. This allows users to work with identical databases. In this way, we test true differences between algorithms and skip any bugs due to the database conversion. Those can now be tested separately by comparing a replay with this new library under analyzer 1.6 with one done with analyzer 1.5.

The OldVDC code is compiled into a plugin library, libOldVDC.so, which can be loaded on demand. I suspect that not many people will want to use this old, obsolete code except for comparison studies.

I've done basic testing of the initialization. Comparison studies are to follow under issue #245.

Actions #2

Updated by Ole Hansen almost 5 years ago

  • Status changed from In Progress to Closed

Replay of GMP12 data with the old (version 1.5) VDC code gives results very close to those of the new code. The ported 1.5 version definitely works. Anything past this point would be an inadvertent bug.

Checked in with commit 7466205. Considering this done.

Actions #3

Updated by Ole Hansen almost 5 years ago

  • % Done changed from 70 to 100
Actions

Also available in: Atom PDF