https://redmine.jlab.org/https://redmine.jlab.org/favicon.ico?16338348402018-01-09T22:04:53ZRedmineHall A Analyzer - Feature #249: Forward-port remaining v1.5 featureshttps://redmine.jlab.org/issues/249?journal_id=3812018-01-09T22:04:53ZOle Hansenole@jlab.org
<ul></ul><p>Forward-ported "initialization of detector event data to kBig instead of 0" (commit <a href="https://github.com/JeffersonLab/analyzer/commit/1a06df8c44791cc437de6b26a36cbf716d3c1b8f" class="external">1a06df8</a>)</p>
<p>This changeset also includes better readability in <code>THaScintillator::TimeWalkCorrection</code> and consistent clearing of <code>fTrackProj</code> via each detector's <code>Clear()</code> method.</p> Hall A Analyzer - Feature #249: Forward-port remaining v1.5 featureshttps://redmine.jlab.org/issues/249?journal_id=3822018-01-09T22:05:17ZOle Hansenole@jlab.org
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>10</i></li></ul> Hall A Analyzer - Feature #249: Forward-port remaining v1.5 featureshttps://redmine.jlab.org/issues/249?journal_id=3832018-01-10T20:05:23ZOle Hansenole@jlab.org
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/383/diff?detail_id=495">diff</a>)</li></ul><p>Added debug printout sections to the <code>Decode</code> and <code>ReadDatabase</code> methods of scintillator, Cherenkov, shower and VDCPlane classes (commit <a href="https://github.com/JeffersonLab/analyzer/commit/0bfcc11ba8d774a9a52a9f34947dcb24108961f9" class="external">0bfcc11</a>). These use the already-existing <code>THaAnalysisObject::DebugPrint</code> method, which now can also handle <code>kDoubleV</code> data, as well as a new method, <code>THaAnalysisObject::WriteValue</code>, that helps with printing out formatted event data that can be kBig.</p> Hall A Analyzer - Feature #249: Forward-port remaining v1.5 featureshttps://redmine.jlab.org/issues/249?journal_id=3842018-01-10T20:05:41ZOle Hansenole@jlab.org
<ul><li><strong>% Done</strong> changed from <i>10</i> to <i>20</i></li></ul> Hall A Analyzer - Feature #249: Forward-port remaining v1.5 featureshttps://redmine.jlab.org/issues/249?journal_id=3852018-01-10T20:32:18ZOle Hansenole@jlab.org
<ul><li><strong>% Done</strong> changed from <i>20</i> to <i>30</i></li></ul><p>Confirmed that the off-by-one shower counter bugfix is already in the master branch ( commit <a href="https://github.com/JeffersonLab/analyzer/commit/e8cfa62a6c68dc13ad28f56f0f72af168d01e2a6" class="external">e8cfa62</a>).</p>
<p>Ported the THaCoincTime improvements from Release-150 to master branch (commit <a href="https://github.com/JeffersonLab/analyzer/commit/371a2f17a7727a0147c9e08753cf0a89f7973c90" class="external">371a2f1</a>).</p> Hall A Analyzer - Feature #249: Forward-port remaining v1.5 featureshttps://redmine.jlab.org/issues/249?journal_id=3862018-01-10T20:59:09ZOle Hansenole@jlab.org
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/386/diff?detail_id=498">diff</a>)</li></ul><p>The following Release-150 improvements have already been cherry picked onto the master branch earlier:</p>
<ul>
<li><code>-Wextra</code> warnings for <code>SCons</code> build</li>
<li>Mistyped "&" instead of "&&" in <code>THaQWEAKHelicityReader</code></li>
<li>Don't report error if <code>THaHelicityDet</code> can't find its database file</li>
<li><code>UserDetector</code>: ignored error statuses</li>
<li><code>DetectorBase</code>: empty detector map is an error</li>
<li>Central angle & rotation matrix calcs in separate functions</li>
</ul> Hall A Analyzer - Feature #249: Forward-port remaining v1.5 featureshttps://redmine.jlab.org/issues/249?journal_id=3872018-01-11T16:15:42ZOle Hansenole@jlab.org
<ul><li><strong>% Done</strong> changed from <i>30</i> to <i>80</i></li></ul><p>A few VDC code changes seemed useful to pick from version 1.5.38:</p>
<ul>
<li>Initialization list in <code>THaVDC</code> constructor</li>
<li>Additional debug messages in <code>THaVDC::ConstructTracks</code></li>
<li>Refactored chi^2 calculation in <code>THaVDCCluster</code></li>
</ul>
<p>Added these features in commit <a href="https://github.com/JeffersonLab/analyzer/commit/3d0d9e12a3f722a2b3868b9e6e511b644471762f" class="external">3d0d9e1</a></p>
<p>The chi^2 calculation may affect the reconstruction slightly, probably in absolutely negligible ways. This should be double-checked, of course.</p>
<p>The cluster track fitting routines in <code>THaVDCCluster</code> seem somewhat unfinished and should be reviewed soon, although we've already tested that they work satisfactorily with low-rate data.</p>
<p>Leaving this issue 80% finished since testing still needs to be done.</p>