Project

General

Profile

Actions

Bug #246

closed

Bug #80: Version 1.6 bugfixes

Prescale event decoding missing

Added by Ole Hansen about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
High
Assignee:
Target version:
Start date:
11/21/2017
Due date:
% Done:

100%

Estimated time:
16.00 h
Spent time:
Responsible:

Description

Handling of prescale events was lost with the move to the object-oriented decoder. We need to write an event type handler for the prescale events. Some initial inspection shows that just adding a handler won't be enough. The prescale factors are needed at run initialization time, for which a separate instance of the decoder is instantiated. Since event type handlers are not part of the decoder anymore, we will now also need to instantiate all event type handlers. But do we really? Event type handlers may include a full analysis chain, but we only need the "RawDecode" part of it. This points to deeper design flaws with the event type handlers. The design needs to be reviewed and additional functionality probably needs to be added.

Aside from the missing prescale decode feature, there is also a bug: Run initialization succeeds if a prescale event is present, regardless of whether prescales have actually been decoded. Successful decoding also needs to be checked.

Actions #1

Updated by Ole Hansen about 5 years ago

  • Subject changed from Add missing prescale event handler to Prescale event decoding missing
Actions #2

Updated by Ole Hansen about 5 years ago

  • Status changed from New to Closed
  • Start date set to 11/21/2017
  • % Done changed from 10 to 100

After investigating this issue for a while, I've decided to take the simple route for now and restore the old prescale decoding code right in the CodaDecoder class, i.e. not to move prescale decoding into an event type handler module. We will need to revisit this issue in version 1.7 because it will likely involve some redesign.

For more details about the problem, see the relevant git commit d5ea96c

Closing this for now and will open a new issue as a Feature Request for version 1.7.

Actions

Also available in: Atom PDF