Bug #349

F1TDCModule needs a 4-arg version of LoadSlot

Added by Robert Michaels over 2 years ago. Updated over 2 years ago.

Status:ClosedStart date:04/24/2018
Priority:NormalDue date:04/26/2018
Assignee:-% Done:

100%

Category:-Estimated time:2.00 hours
Target version:-Spent time:0.50 hour
Responsible:R. Michaels

Description

The Module base class has a 3-arg version and a 4-arg version of LoadSlot. Classes which inherit from this needs to define both, if they are to be used, or the base class's version will be used, which is probably not what we want. I think all this should probably be cleaned up (have only one version) but the quickest solution is to provide a 4-arg version of LoadSlot to F1TDCModule. I notice the other modules have this fix already.

History

#1 Updated by Ole Hansen over 2 years ago

Changed the default implementation of the 4-argument version of Decoder::Module::LoadSlot to a simple wrapper for the 3-arg version, which is a pure virtual method and therefore needs to be implemented by all modules. It is a bit hard to see why the 3-arg and the 4-arg version would ever need different implementations.

Committed on master (commit 00b48e6) and Release-160_patches (commit 0eaaa4f).

#2 Updated by Ole Hansen over 2 years ago

  • Status changed from New to Closed
  • % Done changed from 40 to 100

Also available in: Atom PDF