Project

General

Profile

Actions

Feature #249

open

Task #235: Miscellaneous version 1.6 issues & tasks

Forward-port remaining v1.5 features

Added by Ole Hansen about 4 years ago. Updated about 4 years ago.

Status:
In Progress
Priority:
Normal
Assignee:
-
Target version:
Start date:
Due date:
% Done:

80%

Estimated time:
8.00 h
Spent time:
Responsible:

Description

A few useful updates were made in the Release-150 branch which should be forward-ported to v1.6 before release:

  • initialization of detector event data to kBig instead of 0
  • DebugPrint of database parameters in all detector classes
  • maybe some bits from the v1.5.38 VDC analysis, though most of it is already in v1.6
  • Off-by-one error in shower database reader (probably already done)
  • THaCoincTime improvements
  • -Wextra warnings for SCons build
  • Mistyped "&" instead of "&&" in THaQWEAKHelicityReader
  • Don't report error if THaHelicityDet can't find its database file
  • UserDetector: ignored error statuses
  • DetectorBase: empty detector map is an error
  • Central angle & rotation matrix calcs in separate functions
Actions #1

Updated by Ole Hansen about 4 years ago

Forward-ported "initialization of detector event data to kBig instead of 0" (commit 1a06df8)

This changeset also includes better readability in THaScintillator::TimeWalkCorrection and consistent clearing of fTrackProj via each detector's Clear() method.

Actions #2

Updated by Ole Hansen about 4 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 10
Actions #3

Updated by Ole Hansen about 4 years ago

  • Description updated (diff)

Added debug printout sections to the Decode and ReadDatabase methods of scintillator, Cherenkov, shower and VDCPlane classes (commit 0bfcc11). These use the already-existing THaAnalysisObject::DebugPrint method, which now can also handle kDoubleV data, as well as a new method, THaAnalysisObject::WriteValue, that helps with printing out formatted event data that can be kBig.

Actions #4

Updated by Ole Hansen about 4 years ago

  • % Done changed from 10 to 20
Actions #5

Updated by Ole Hansen about 4 years ago

  • % Done changed from 20 to 30

Confirmed that the off-by-one shower counter bugfix is already in the master branch ( commit e8cfa62).

Ported the THaCoincTime improvements from Release-150 to master branch (commit 371a2f1).

Actions #6

Updated by Ole Hansen about 4 years ago

  • Description updated (diff)

The following Release-150 improvements have already been cherry picked onto the master branch earlier:

  • -Wextra warnings for SCons build
  • Mistyped "&" instead of "&&" in THaQWEAKHelicityReader
  • Don't report error if THaHelicityDet can't find its database file
  • UserDetector: ignored error statuses
  • DetectorBase: empty detector map is an error
  • Central angle & rotation matrix calcs in separate functions
Actions #7

Updated by Ole Hansen about 4 years ago

  • % Done changed from 30 to 80

A few VDC code changes seemed useful to pick from version 1.5.38:

  • Initialization list in THaVDC constructor
  • Additional debug messages in THaVDC::ConstructTracks
  • Refactored chi^2 calculation in THaVDCCluster

Added these features in commit 3d0d9e1

The chi^2 calculation may affect the reconstruction slightly, probably in absolutely negligible ways. This should be double-checked, of course.

The cluster track fitting routines in THaVDCCluster seem somewhat unfinished and should be reviewed soon, although we've already tested that they work satisfactorily with low-rate data.

Leaving this issue 80% finished since testing still needs to be done.

Actions

Also available in: Atom PDF