Project

General

Profile

Actions

Bug #265

closed

Bug #80: Version 1.6 bugfixes

Static variable in PipeliningModule::SplitBuffer

Added by Ole Hansen almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
02/22/2018
Due date:
03/12/2018
% Done:

100%

Estimated time:
12.00 h
Spent time:
Responsible:
R. Michaels

Description

The variable data_type_def is declared static in PipeliningModile::SplitBuffer, which makes it global for all instances of PipeliningModule. It seems to me that this cannot be right.

See GitHub issue #151: https://github.com/JeffersonLab/analyzer/issues/151


Related issues

Related to Feature #274: CODA 3 data formatIn ProgressRobert Michaels03/01/2018

Actions
Actions #1

Updated by Robert Michaels almost 5 years ago

  • Due date set to 02/28/2018
  • Status changed from New to In Progress
  • Start date set to 02/23/2018
  • % Done changed from 0 to 30
  • Responsible set to R. Michaels

The fix proposed by Ole for this "static variable" question is probably fine, but I wanted to test it on some data to be sure. I used my DAQ test stand for that. Around the same time, I happened to have upgraded that DAQ to CODA 3.07 and, long story short, I could not analyze any data because the event structure is different. So, as a side-issue we need to make the analyzer "CODA version independent". I think I know how to do that now and can test this bug-fix. We'll keep the two issues separate. I think we will want to use CODA 3 eventually, it's a lot simpler and more stable than CODA 2.6.2, also the pipelining is is dealt with more naturally in EVIO 4.

Actions #2

Updated by Ole Hansen over 4 years ago

Actions #3

Updated by Robert Michaels over 4 years ago

  • Due date set to 03/12/2018
  • Status changed from In Progress to Resolved
  • Start date set to 02/22/2018
  • % Done changed from 0 to 100
  • Estimated time set to 12.00 h
Actions #4

Updated by Ole Hansen over 4 years ago

  • Status changed from Resolved to Closed

Closed with commit e795ce1

Actions

Also available in: Atom PDF